[webkit-reviews] review canceled: [Bug 213884] [WK2] Add API to allow embedder to set a timezone override : [Attachment 411545] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 16 03:18:14 PDT 2020


Philippe Normand <pnormand at igalia.com> has canceled Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 213884: [WK2] Add API to allow embedder to set a timezone override
https://bugs.webkit.org/show_bug.cgi?id=213884

Attachment 411545: Patch

https://bugs.webkit.org/attachment.cgi?id=411545&action=review




--- Comment #34 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 411545
  --> https://bugs.webkit.org/attachment.cgi?id=411545
Patch

Failed
    TestWebKitAPI.TimeZoneOverrideTest.TimeZoneOverride
	_RegisterApplication(), FAILED TO establish the default connection to
the WindowServer, _CGSDefaultConnection() is NULL.

       
/Volumes/Data/worker/macOS-Mojave-Release-Build-EWS/build/Tools/TestWebKitAPI/T
ests/WebKitCocoa/TimeZoneOverride.mm:66
	Expected equality of these values:
	  [result stringValue]
	    Which is: "420"
	  "-120"


More information about the webkit-reviews mailing list