[webkit-reviews] review granted: [Bug 217750] [GStreamer] Encoder probing support for the registry scanner : [Attachment 411427] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 217750: [GStreamer] Encoder probing support for the registry scanner
https://bugs.webkit.org/show_bug.cgi?id=217750

Attachment 411427: Patch

https://bugs.webkit.org/attachment.cgi?id=411427&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 411427
  --> https://bugs.webkit.org/attachment.cgi?id=411427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411427&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:175
> +	   Optional<HashSet<String, ASCIICaseInsensitiveHash>> mimeTypeSet;
> +	   Optional<HashMap<AtomString, bool>> codecMap;

Why do you need to make this Optional if you're not checking if the value is
there?

> Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h:47
> +    HashSet<String, ASCIICaseInsensitiveHash>& mimeTypeSet(Configuration);

Can't you return a const here?