[webkit-reviews] review granted: [Bug 217725] [WebGPU] Centralize Platform Defines : [Attachment 411473] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 15 17:06:32 PDT 2020

Myles C. Maxfield <mmaxfield at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 217725: [WebGPU] Centralize Platform Defines

Attachment 411473: Patch


--- Comment #6 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 411473
  --> https://bugs.webkit.org/attachment.cgi?id=411473

View in context: https://bugs.webkit.org/attachment.cgi?id=411473&action=review

Good cleanup.

> Source/WebCore/platform/graphics/gpu/cocoa/GPUPlatformTypes.h:1
> +/*

IIRC it's impossible (or maybe just error-prone?) to have two files with the
same name in different directories. If that's true, then this will have to be
moved out of cocoa/ and have PLATFORM guards inside the file.

More information about the webkit-reviews mailing list