[webkit-reviews] review denied: [Bug 217784] Create API to enable/disable text interaction gestures in WKWebView : [Attachment 411506] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 15 16:33:13 PDT 2020


Alex Christensen <achristensen at apple.com> has denied
katherine_cheney at apple.com's request for review:
Bug 217784: Create API to enable/disable text interaction gestures in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=217784

Attachment 411506: Patch

https://bugs.webkit.org/attachment.cgi?id=411506&action=review




--- Comment #11 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 411506
  --> https://bugs.webkit.org/attachment.cgi?id=411506
Patch

This shouldn't be on WKWebView.  It should be on WKWebViewConfiguration if it's
something that shouldn't change during the lifetime of the WKWebView and
WKPreferences otherwise.  Also, the boolean is backed only by ObjC, which is
something we try to avoid in WebKit, where the ObjC layer is just a thin
wrapper around the C++ objects.


More information about the webkit-reviews mailing list