[webkit-reviews] review granted: [Bug 217790] [WebAuthn] Move AppAttestInternal related code from WKA to OpenSource : [Attachment 411503] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 217790: [WebAuthn] Move AppAttestInternal related code from WKA to
OpenSource
https://bugs.webkit.org/show_bug.cgi?id=217790

Attachment 411503: Patch

https://bugs.webkit.org/attachment.cgi?id=411503&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 411503
  --> https://bugs.webkit.org/attachment.cgi?id=411503
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411503&action=review

r=mews

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.h:28
> +#import <wtf/SoftLinking.h>

I wonder if you need this if APPLE_ATTESTATION is not defined?

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.mm:28
> +#import <wtf/SoftLinking.h>

I wonder if you even need to include this if the build does not have
APPLE_ATTESTATION defined?