[webkit-reviews] review granted: [Bug 214861] [JSC] support op_get_private_name in DFG and FTL : [Attachment 411457] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 214861: [JSC] support op_get_private_name in DFG and FTL
https://bugs.webkit.org/show_bug.cgi?id=214861

Attachment 411457: Patch

https://bugs.webkit.org/attachment.cgi?id=411457&action=review




--- Comment #35 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 411457
  --> https://bugs.webkit.org/attachment.cgi?id=411457
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411457&action=review

This looks pretty reasonable. I think the only thing I’d change is to use
handleGetById instead of adding a new function. Just give that thing an enum
arg or whatever to tell it to do private mode, and gate a bunch of stuff in
there on that. That keeps you from duplicating logic that I think is a bit
gnarly. R=me with that comment.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3477
> +    speculate(node, node->child1());

This is weird. Can’t imagine this doing smart codegen. Why aren’t we doing
SpeculateCellOperand?