[webkit-reviews] review granted: [Bug 217745] Fix for multiple accessibility layout tests in isolated tree mode. : [Attachment 411394] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 217745: Fix for multiple accessibility layout tests in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=217745

Attachment 411394: Patch

https://bugs.webkit.org/attachment.cgi?id=411394&action=review




--- Comment #5 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 411394
  --> https://bugs.webkit.org/attachment.cgi?id=411394
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411394&action=review

>>> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1142
>>> +	 auto* axObject = associatedAXObject();
>> 
>> I think we would need to retrieve this on the main thread
> 
> The caller needs to dispatch this call the main thread because it returns a
SimpleRange. So it doesn't make sense to dispatch here. in Debug mode this is
enforced with the assert in associatedAXObject.

should we put an assert mainThread() here just in case? it wasn't clear to me
this method would require main thread usage already