[webkit-reviews] review denied: [Bug 217735] [GPU Process] Enable ImageBitmap and OffscreenCanvas drawing to go through the GPU Process : [Attachment 411416] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 217735: [GPU Process] Enable ImageBitmap and OffscreenCanvas drawing to go
through the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=217735

Attachment 411416: Patch

https://bugs.webkit.org/attachment.cgi?id=411416&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 411416
  --> https://bugs.webkit.org/attachment.cgi?id=411416
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411416&action=review

> Source/WebCore/html/ImageBitmap.cpp:84
> +    auto document = scriptExecutionContext.isDocument() ?
&downcast<Document>(scriptExecutionContext) : nullptr;
> +    auto hostWindow = (document && document->view() &&
document->view()->root()) ? document->view()->root()->hostWindow() : nullptr;

ImageBitmap is:

Exposed=(Window,Worker),

so this needs to work in Workers too, where scriptExecutionContext.isDocument()
will be false.