[webkit-reviews] review granted: [Bug 217749] [Cocoa] Don't change the text matrix multiple times inside FontCascade::drawGlyphs() : [Attachment 411415] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 15 09:59:35 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 217749: [Cocoa] Don't change the text matrix multiple times inside
FontCascade::drawGlyphs()
https://bugs.webkit.org/show_bug.cgi?id=217749

Attachment 411415: Patch

https://bugs.webkit.org/attachment.cgi?id=411415&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 411415
  --> https://bugs.webkit.org/attachment.cgi?id=411415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411415&action=review

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:144
> +    if (!platformData.isColorBitmapFont())

Why are color bitmap fonts special?


More information about the webkit-reviews mailing list