[webkit-reviews] review granted: [Bug 177723] EWS bot should fail if a new test is missing its result : [Attachment 411436] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 177723: EWS bot should fail if a new test is missing its result
https://bugs.webkit.org/show_bug.cgi?id=177723

Attachment 411436: Patch

https://bugs.webkit.org/attachment.cgi?id=411436&action=review




--- Comment #6 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 411436
  --> https://bugs.webkit.org/attachment.cgi?id=411436
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411436&action=review

>> Tools/BuildSlaveSupport/ews-build/steps.py:2000
>> +		    elif line.find('missing results') >= 0:
> 
> Added this elif explicitly for readability. Can remove this as well if
reviewers feel strongly about it.

I'm fine with the elif, but it seems like the failure condition should be
first. (since in the event a line contained both 'flakes' and 'missing
results', we would want to mark the build as failed). I know this concern is
more about purity than practicality at the moment, though.