[webkit-reviews] review granted: [Bug 217743] Vectorize downmixing in AudioBus::createByMixingToMono() : [Attachment 411391] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217743: Vectorize downmixing in AudioBus::createByMixingToMono()
https://bugs.webkit.org/show_bug.cgi?id=217743

Attachment 411391: Patch

https://bugs.webkit.org/attachment.cgi?id=411391&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 411391
  --> https://bugs.webkit.org/attachment.cgi?id=411391
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411391&action=review

> Source/WebCore/platform/audio/VectorMath.cpp:697
> +    VectorMath::add(inputVector1, inputVector2, outputVector,
numberOfElementsToProcess);
> +    VectorMath::multiplyByScalar(outputVector, scalar, outputVector,
numberOfElementsToProcess);

We are in the VectorMath namespace, so no need to restate the namespace as a
prefix.