[webkit-reviews] review granted: [Bug 215206] Support AXCoreObject::elementPath for text elements. : [Attachment 411324] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 14 15:08:18 PDT 2020


chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 215206: Support AXCoreObject::elementPath for text elements.
https://bugs.webkit.org/show_bug.cgi?id=215206

Attachment 411324: Patch

https://bugs.webkit.org/attachment.cgi?id=411324&action=review




--- Comment #7 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 411324
  --> https://bugs.webkit.org/attachment.cgi?id=411324
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411324&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913
> +	   for (size_t i = 1; i < rects.size(); ++i) {

can you cache rects.size() outside of the loop


More information about the webkit-reviews mailing list