[webkit-reviews] review granted: [Bug 175432] Use @putByValDirect instead of Array.prototype. at push in built-ins : [Attachment 411364] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 175432: Use @putByValDirect instead of Array.prototype. at push in built-ins
https://bugs.webkit.org/show_bug.cgi?id=175432

Attachment 411364: Patch

https://bugs.webkit.org/attachment.cgi?id=411364&action=review




--- Comment #9 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 411364
  --> https://bugs.webkit.org/attachment.cgi?id=411364
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411364&action=review

r=me with one comment.

> Source/JavaScriptCore/builtins/RegExpPrototype.js:132
>	   if (!resultString.length)

Can you change the other code like that to @arrayPush too?

`@putByValDirect(xxx, xxx.length, yyy)`

For example, RegExpPrototype.js includes some code like this.

@putByValDirect(result, result.length, subStr);

ArrayPrototype.js also has similar one.