[webkit-reviews] review granted: [Bug 217710] Introduce a RemoteAudioSourceProvider to receive audio samples for web audio from GPUProcess : [Attachment 411331] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 217710: Introduce a RemoteAudioSourceProvider to receive audio samples for
web audio from GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=217710

Attachment 411331: Patch

https://bugs.webkit.org/attachment.cgi?id=411331&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 411331
  --> https://bugs.webkit.org/attachment.cgi?id=411331
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411331&action=review

> Source/WebCore/ChangeLog:9
> +	   This allows reusing WebAudioSourceProviderAVFObjC for samples coming
from video playback living in GPUProcess.

s/video playback/audio playback/

>
Source/WebCore/platform/mediastream/mac/MediaStreamTrackAudioSourceProviderAVFO
bjC.h:36
> +class MediaStreamTrackAudioSourceProviderAVFObjC final

Nit: it looks like this class doesn't use AVFoundation, so we could rename it.
`MediaStreamTrackAudioSourceProviderCocoa` maybe?

> Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h:54
> +class WEBCORE_EXPORT WebAudioSourceProviderAVFObjC

Ditto.