[webkit-reviews] review granted: [Bug 217711] Refactor HighlightData : [Attachment 411347] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 14 11:54:02 PDT 2020

Darin Adler <darin at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 217711: Refactor HighlightData

Attachment 411347: Patch


--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 411347
  --> https://bugs.webkit.org/attachment.cgi?id=411347

This looks great. I have some additional ideas for refinement here;
HighlightData itself can be simplified further; I’m not sure we even need the
concept of RenderRange; we can probably just use SimpleRange instead.

More information about the webkit-reviews mailing list