[webkit-reviews] review canceled: [Bug 217712] WeakObjCPtr.h is not safe to include in C++ source files : [Attachment 411337] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 14 09:52:17 PDT 2020


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 217712: WeakObjCPtr.h is not safe to include in C++ source files
https://bugs.webkit.org/show_bug.cgi?id=217712

Attachment 411337: Patch v1

https://bugs.webkit.org/attachment.cgi?id=411337&action=review




--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 411337
  --> https://bugs.webkit.org/attachment.cgi?id=411337
Patch v1

Well, this is trickier than I thought!

In file included from
/Volumes/Data/worker/tvOS-14-Build-EWS/build/WebKitBuild/Release-appletvos/Deri
vedSources/WebKit2/RemoteObjectRegistryMessageReceiver.cpp:27:
/Volumes/Data/worker/tvOS-14-Build-EWS/build/Source/WebKit/Shared/API/Cocoa/Rem
oteObjectRegistry.h:71:5: error: no template named 'WeakObjCPtr'

<https://ews-build.webkit.org/#/builders/48/builds/753/steps/7/logs/errors>


More information about the webkit-reviews mailing list