[webkit-reviews] review granted: [Bug 209872] [css-flexbox] flex-grow property should be animatable : [Attachment 411314] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 209872: [css-flexbox] flex-grow property should be animatable
https://bugs.webkit.org/show_bug.cgi?id=209872

Attachment 411314: Patch

https://bugs.webkit.org/attachment.cgi?id=411314&action=review




--- Comment #2 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 411314
  --> https://bugs.webkit.org/attachment.cgi?id=411314
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411314&action=review

r+ assuming EWS bots are happy as well, thanks for adding this.

> Source/WebCore/rendering/style/RenderStyle.h:1104
> +    void setFlexGrow(float f) { float v = std::max<float>(f, 0.f);
SET_NESTED_VAR(m_rareNonInheritedData, flexibleBox, flexGrow, v); }

Perhaps spell out what `v` stands for here. Since you're clamping, perhaps call
that out in the variable name.