[webkit-reviews] review canceled: [Bug 217685] Cache JS arguments in AudioWorkletProcessor::process() for performance : [Attachment 411286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 13 20:51:10 PDT 2020


Chris Dumez <cdumez at apple.com> has canceled Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217685: Cache JS arguments in AudioWorkletProcessor::process() for
performance
https://bugs.webkit.org/show_bug.cgi?id=217685

Attachment 411286: Patch

https://bugs.webkit.org/attachment.cgi?id=411286&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 411286
  --> https://bugs.webkit.org/attachment.cgi?id=411286
Patch

Ok. I will look into using JSValueInWrappedObject tomorrow. I see that it has a
visit() function, I guess this is what I need to do to keep those arrays alive.


More information about the webkit-reviews mailing list