[webkit-reviews] review granted: [Bug 217682] Web Inspector: REGRESSION(r267148): new Big Sur styles are not used : [Attachment 411279] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 217682: Web Inspector: REGRESSION(r267148): new Big Sur styles are not used
https://bugs.webkit.org/show_bug.cgi?id=217682

Attachment 411279: Patch

https://bugs.webkit.org/attachment.cgi?id=411279&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 411279
  --> https://bugs.webkit.org/attachment.cgi?id=411279
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411279&action=review

The approach is sane, and I couldn't find any mistakes.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:392
> +String InspectorFrontendHost::platformVersionName() const

Reminder to future self, we need to update this every year. =)

> Source/WebInspectorUI/UserInterface/Views/Popover.js:238
> +	   var titleBarOffset = WI.undockedTitleAreaHeight();

Yikes, this is definitely an improvement in clarity.