[webkit-reviews] review requested: [Bug 217668] Null dereference in PDFPlugin::snapshot() : [Attachment 411267] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 217668: Null dereference in PDFPlugin::snapshot()
https://bugs.webkit.org/show_bug.cgi?id=217668

Attachment 411267: Patch

https://bugs.webkit.org/attachment.cgi?id=411267&action=review




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 411267
  --> https://bugs.webkit.org/attachment.cgi?id=411267
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411267&action=review

> LayoutTests/plugins/pdf-plugin-null-onloaddeddata.html:4
> +/*begincss*/

This comment is useless. Please remove it.

> LayoutTests/plugins/pdf-plugin-null-onloaddeddata.html:5
> +:not(glyphRef) { zoom: 61; }

Do we really need it?
If we do, I presume we only need it on body or embed so I'd suggest either one
of:
embed { zoom: 61; }
body { zoom: 61; }
embed, body { zoom: 61; }

> LayoutTests/plugins/pdf-plugin-null-onloaddeddata.html:6
> +/*endcss*/

Ditto.