[webkit-reviews] review granted: [Bug 217661] transform-origin is applied on top of invidivual CSS transform properties on composited layers : [Attachment 411234] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 217661: transform-origin is applied on top of invidivual CSS transform
properties on composited layers
https://bugs.webkit.org/show_bug.cgi?id=217661

Attachment 411234: Patch

https://bugs.webkit.org/attachment.cgi?id=411234&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 411234
  --> https://bugs.webkit.org/attachment.cgi?id=411234
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411234&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:1389
> +    bool applyTransformOrigin =
options.contains(RenderStyle::TransformOperationOption::TransformOrigin) &&
(m_rareNonInheritedData->rotate || m_rareNonInheritedData->scale ||
transformOperations.affectedByTransformOrigin());

m_rareNonInheritedData->rotate and m_rareNonInheritedData->scale may still be
no-op values.