[webkit-reviews] review granted: [Bug 217663] WebAudio tests are crashing in debug when enabling the GPU process : [Attachment 411240] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 13 13:19:56 PDT 2020
Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217663: WebAudio tests are crashing in debug when enabling the GPU process
https://bugs.webkit.org/show_bug.cgi?id=217663
Attachment 411240: Patch
https://bugs.webkit.org/attachment.cgi?id=411240&action=review
--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 411240
--> https://bugs.webkit.org/attachment.cgi?id=411240
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=411240&action=review
r=me
> Source/WTF/ChangeLog:13
> + deque (since the queue is empty).
dequeue
> Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:115
> + audioBus->setChannelMemory(i,
(float*)buffers[i]->data(), framesToProcess);
static_cast<float*>
More information about the webkit-reviews
mailing list