[webkit-reviews] review granted: [Bug 217565] IPC testing JS API should expose a reply and describe the list of arguments for each message : [Attachment 411242] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 217565: IPC testing JS API should expose a reply and describe the list of
arguments for each message
https://bugs.webkit.org/show_bug.cgi?id=217565

Attachment 411242: Patch

https://bugs.webkit.org/attachment.cgi?id=411242&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 411242
  --> https://bugs.webkit.org/attachment.cgi?id=411242
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411242&action=review

r=me

> Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:151
> +	   { "sessionID", sessionID, 0, kJSPropertyAttributeDontDelete |
kJSPropertyAttributeReadOnly },
> +	   { "pageIdentifier", pageIdentifier, 0,
kJSPropertyAttributeDontDelete | kJSPropertyAttributeReadOnly },

How about naming these sessionID and pageID, to keep our JavaScript code
consistent.