[webkit-reviews] review granted: [Bug 217637] 'parameters' argument to AudioWorkletProcessor.process() is not spec-compliant : [Attachment 411172] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217637: 'parameters' argument to AudioWorkletProcessor.process() is not
spec-compliant
https://bugs.webkit.org/show_bug.cgi?id=217637

Attachment 411172: Patch

https://bugs.webkit.org/attachment.cgi?id=411172&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 411172
  --> https://bugs.webkit.org/attachment.cgi?id=411172
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411172&action=review

> Source/WebCore/ChangeLog:12
> +	   Its type should not be a JS Map, as evidenced by how WPT tests use
it. We now pass a generic JS Object,
> +	   as Blink is doing.

I understand that the test helped make this clear. Was it also clear in the
specification, or do we need to file an issue to ask for it to be made clearer.

> Source/WebCore/ChangeLog:15
> +	   Also, as per the specification, if no automation is scheduled during
the render quantum, the array may
> +	   have length 1 with the array element being the constant value of the
AudioParam for the render quantum.

Not sure I understand the word "may" here. Does this mean it "must"?

> Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:997
> +    auto endFrame = startFrame + AudioUtilities::renderQuantumSize;

What if someone passes a really huge startFrame in, like
numeric_limits<size_t>::max()? Should we return true in that case instead of
overflowing? Or is that impossible?