[webkit-reviews] review granted: [Bug 217578] Webcam video from navigator.mediaDevices.getUserMedia() to 2D canvas fails on Safari on iPhone : [Attachment 411209] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 217578: Webcam video from navigator.mediaDevices.getUserMedia() to 2D
canvas fails on Safari on iPhone
https://bugs.webkit.org/show_bug.cgi?id=217578

Attachment 411209: Patch

https://bugs.webkit.org/attachment.cgi?id=411209&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 411209
  --> https://bugs.webkit.org/attachment.cgi?id=411209
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411209&action=review

> Source/WebCore/platform/graphics/MediaPlayer.cpp:968
> +void MediaPlayer::setVisibleForCanvas(bool b)
> +{
> +    m_visible = b;
> +    m_private->setVisibleForCanvas(b);

s/b/visible/

> Source/WebCore/platform/graphics/MediaPlayerPrivate.h:99
> +    virtual void setVisibleForCanvas(bool b) { setVisible(b); }

Ditto