[webkit-reviews] review granted: [Bug 217647] [GStreamer] Crash in WebCore::GStreamerRegistryScanner::isAVC1CodecSupported : [Attachment 411204] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 13 03:43:30 PDT 2020

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 217647: [GStreamer] Crash in

Attachment 411204: Patch


--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 411204
  --> https://bugs.webkit.org/attachment.cgi?id=411204

View in context: https://bugs.webkit.org/attachment.cgi?id=411204&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:367
> +    auto checkH264Caps = [&](const char* capsString) {

Nit: I would do this a private method instead of a lambda, even if this was
already like this before.

> Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:370
> +	   bool supported = false;
> +	   auto lookupResult = hasElementForMediaType(m_videoDecoderFactories,
capsString, true);
> +	   supported = lookupResult;

Nit: I think one line would be enough, wouldn't it?

More information about the webkit-reviews mailing list