[webkit-reviews] review granted: [Bug 216038] [SOUP] webkit_web_view_get_https_status() broken with service workers : [Attachment 411088] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 13 01:07:45 PDT 2020


Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 216038: [SOUP] webkit_web_view_get_https_status() broken with service
workers
https://bugs.webkit.org/show_bug.cgi?id=216038

Attachment 411088: Patch

https://bugs.webkit.org/attachment.cgi?id=411088&action=review




--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 411088
  --> https://bugs.webkit.org/attachment.cgi?id=411088
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411088&action=review

> Source/WebCore/platform/network/soup/CertificateInfoSoup.cpp:73
> +    RELEASE_ASSERT(!error);

Since you are using the GError just to assert it should never fail, why not
just pass nullptr and assert cert is not nullptr?


More information about the webkit-reviews mailing list