[webkit-reviews] review denied: [Bug 217635] Elements in Shadow DOM are wrongly marked as stale by the WebDriver : [Attachment 411160] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied linkgoron
<webkitbugzilla at steakexchange.com>'s request for review:
Bug 217635: Elements in Shadow DOM are wrongly marked as stale by the WebDriver
https://bugs.webkit.org/show_bug.cgi?id=217635

Attachment 411160: Patch

https://bugs.webkit.org/attachment.cgi?id=411160&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 411160
  --> https://bugs.webkit.org/attachment.cgi?id=411160
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411160&action=review

> Source/WebDriver/Session.cpp:2088
> +		       "    var activeElement = doc.activeElement;"

Please use let instead of var like the rest of the function.

> Source/WebDriver/Session.cpp:2090
> +		       "       var shadowRoot = activeElement.shadowRoot;"

This will only work with open shadow roots. That's not right.

> Source/WebDriver/Session.cpp:2098
> +		       "    if (element != activeElement)"

This will do that trick:
element != element.getRootNode().activeElement