[webkit-reviews] review granted: [Bug 212580] CSS "any-pointer:fine" media query false on iPad/Pencil : [Attachment 411154] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 212580: CSS "any-pointer:fine" media query false on iPad/Pencil
https://bugs.webkit.org/show_bug.cgi?id=212580

Attachment 411154: Patch

https://bugs.webkit.org/attachment.cgi?id=411154&action=review




--- Comment #19 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 411154
  --> https://bugs.webkit.org/attachment.cgi?id=411154
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411154&action=review

> Source/WebKit/UIProcess/ios/WKStylusDeviceObserver.mm:67
> +- (void)dealloc

I still think we should just remove these `-dealloc`s, since it's dead code.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSStylusSupport.mm:173
> +    WKStylusDeviceObserver *stylusDeviceObserver =
[NSClassFromString(@"WKStylusDeviceObserver") sharedInstance];
> +    [stylusDeviceObserver start];
> +    stylusDeviceObserver.hasStylusDevice = YES;
> +
> +    auto webView = adoptNS([[TestWKWebView alloc]
initWithFrame:NSMakeRect(0, 0, 800, 600)]);
> +
> +    [webView synchronouslyLoadHTMLString:@""];
> +
> +    [stylusDeviceObserver startChangeTimer:0.01];

Nit - it might be a bit cleaner if you pulled this test setup logic out into a
separate helper function.