[webkit-reviews] review granted: [Bug 217632] [webkitcorepy] Attempt to terminate stuck processes before killing them : [Attachment 411163] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 217632: [webkitcorepy] Attempt to terminate stuck processes before killing
them
https://bugs.webkit.org/show_bug.cgi?id=217632

Attachment 411163: Patch

https://bugs.webkit.org/attachment.cgi?id=411163&action=review




--- Comment #7 from dewei_zhu at apple.com ---
Comment on attachment 411163
  --> https://bugs.webkit.org/attachment.cgi?id=411163
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411163&action=review

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/subprocess_utils.py:137
>	       process.wait()

Not sure if this is related to the initial problem this patch intends to
address.
Would this cause deadlock when
1. timeout is specified &
2. huge amount of output is produced to subprocess.PIPE
3. program hits the timeout
Per the warning from
https://docs.python.org/2.7/library/subprocess.html#subprocess.Popen.wait