[webkit-reviews] review granted: [Bug 217612] [WebIDL] convertRecord() should handle duplicate keys for USVString records : [Attachment 411134] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 12 11:43:30 PDT 2020


Sam Weinig <sam at webkit.org> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 217612: [WebIDL] convertRecord() should handle duplicate keys for USVString
records
https://bugs.webkit.org/show_bug.cgi?id=217612

Attachment 411134: Patch

https://bugs.webkit.org/attachment.cgi?id=411134&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 411134
  --> https://bugs.webkit.org/attachment.cgi?id=411134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411134&action=review

> LayoutTests/imported/w3c/ChangeLog:9
> +	   *
web-platform-tests/url/urlsearchparams-constructor.any-expected.txt:
> +	   * web-platform-tests/url/urlsearchparams-constructor.any.js:

Usually we don't modify the imported tests directly, or if we do, try to get
that change integrated upstream as well. Is this something you plan to do with
this change?


More information about the webkit-reviews mailing list