[webkit-reviews] review granted: [Bug 217531] Use AudioWorkletProcessor to process audio : [Attachment 410987] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217531: Use AudioWorkletProcessor to process audio
https://bugs.webkit.org/show_bug.cgi?id=217531

Attachment 410987: Patch

https://bugs.webkit.org/attachment.cgi?id=410987&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 410987
  --> https://bugs.webkit.org/attachment.cgi?id=410987
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410987&action=review

> Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp:120
>      JSC::JSObject* jsConstructor = constructor->callbackData()->callback();

auto*

> Source/WebCore/Modules/webaudio/AudioWorkletNode.cpp:278
> +	       errorMessage = "An error was thrown from
AudioWorkletProcessor::process() method"_s;

Do other browsers provide information on the exception that was thrown in the
worklet?

> Source/WebCore/Modules/webaudio/AudioWorkletNode.h:34
> +#include "AudioArray.h"

Forward declare AudioFloatArray?

> Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp:56
> +static JSMap* constructJSMap(VM& vm, JSGlobalObject* globalObject, const
HashMap<String, std::unique_ptr<AudioFloatArray>>& paramValuesMap)

Can we pass a JSGlobalObject& in all these methods?

> Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp:86
> +static void copyDataFromJSArrayToBuses(JSGlobalObject* globalObject,
JSArray* jsArray, Vector<RefPtr<AudioBus>>& buses)

JSArray&.
Maybe also Vector<Ref<>> since we are assuming buses are not null.