[webkit-reviews] review granted: [Bug 217584] Ignore deployment suffix and identifier when computing major OS version for macOS Big Sur and newer : [Attachment 411070] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Luming Yin <luming_yin at apple.com>'s
request for review:
Bug 217584: Ignore deployment suffix and identifier when computing major OS
version for macOS Big Sur and newer
https://bugs.webkit.org/show_bug.cgi?id=217584

Attachment 411070: Patch

https://bugs.webkit.org/attachment.cgi?id=411070&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 411070
  --> https://bugs.webkit.org/attachment.cgi?id=411070
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411070&action=review

> Source/JavaScriptCore/Configurations/Base.xcconfig:106
> +TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 =
$(MACOSX_DEPLOYMENT_TARGET:base)$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)

I think this should use "10" instead of "$(MACOSX_DEPLOYMENT_TARGET:base)"