[webkit-reviews] review granted: [Bug 216533] [WebIDL] %Interface%.prototype.constructor should be defined on [[Set]] receiver : [Attachment 411057] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 216533: [WebIDL] %Interface%.prototype.constructor should be defined on
[[Set]] receiver
https://bugs.webkit.org/show_bug.cgi?id=216533

Attachment 411057: Patch

https://bugs.webkit.org/attachment.cgi?id=411057&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 411057
  --> https://bugs.webkit.org/attachment.cgi?id=411057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411057&action=review

> Source/JavaScriptCore/runtime/CustomGetterSetter.h:79
> +JS_EXPORT_PRIVATE Optional<bool> callCustomSetter(JSGlobalObject*,
CustomGetterSetter::CustomSetter, bool isAccessor, JSObject* slotBase, JSValue
thisValue, JSValue);

Sam Weinig has argued that Optional<bool> is too confusing a type to ever be
used for anything. In this case, I must admit it’s not clear to me what the
three different return values are and what they mean. Could just return a
custom enumeration to make that clearer?