[webkit-reviews] review granted: [Bug 217551] Use WebPreference definitions from shared configuration files in WebCore (Part 1) : [Attachment 411012] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 217551: Use WebPreference definitions from shared configuration files in
WebCore (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=217551

Attachment 411012: Patch

https://bugs.webkit.org/attachment.cgi?id=411012&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 411012
  --> https://bugs.webkit.org/attachment.cgi?id=411012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411012&action=review

> Source/WTF/ChangeLog:20
> +	   This also adds some new keys from WebCore's Settings.yaml:

Not thrilled with the "webcore" prefix.

> Source/WTF/ChangeLog:21
> +	   - 'webcoreOnChange: *' called by WebCore::Settings when the setting
changes.

There’s something really strange about having WebCore function names in WTF. I
could easily imagine overlooking these when doing a global search.