[webkit-reviews] review granted: [Bug 217528] [Media in GPU Process] Enable audio routing arbitration on Mac : [Attachment 410965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 9 13:58:21 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 217528: [Media in GPU Process] Enable audio routing arbitration on Mac
https://bugs.webkit.org/show_bug.cgi?id=217528

Attachment 410965: Patch

https://bugs.webkit.org/attachment.cgi?id=410965&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 410965
  --> https://bugs.webkit.org/attachment.cgi?id=410965
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410965&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp:78
> +#elif PLATFORM(MAC)
> +    AudioSession::setCategory(type, policy);
> +#else

Please add a FIXME here and reference the bug that will move
AudioSessionRoutingArbitratorProxy to the GPU process.


More information about the webkit-reviews mailing list