[webkit-reviews] review granted: [Bug 217500] [JSC] Assert Operation and HostFunction are in JITOperationsList : [Attachment 410954] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 9 11:32:30 PDT 2020

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 217500: [JSC] Assert Operation and HostFunction are in JITOperationsList

Attachment 410954: Patch


--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 410954
  --> https://bugs.webkit.org/attachment.cgi?id=410954

View in context: https://bugs.webkit.org/attachment.cgi?id=410954&action=review

> Source/WTF/wtf/PtrTag.h:52
> +enum class PtrTagCalledFromType : uint8_t { CalledFromNative, CalledFromJIT,
NotCalled };

Should we call this PtrTagCallerType?

If not, I don’t think you need to repeat “CalledFrom” in the enum values.

> Source/WTF/wtf/PtrTag.h:53
> +enum class PtrTagTargetType : uint8_t { Native, JIT, };

And this PtrTagCalleeType?

More information about the webkit-reviews mailing list