[webkit-reviews] review granted: [Bug 217483] [macOS] Issue sandbox extension for icon service when attachment element is enabled : [Attachment 410875] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 217483: [macOS] Issue sandbox extension for icon service when attachment
element is enabled
https://bugs.webkit.org/show_bug.cgi?id=217483

Attachment 410875: Patch

https://bugs.webkit.org/attachment.cgi?id=410875&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 410875
  --> https://bugs.webkit.org/attachment.cgi?id=410875
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410875&action=review

Nice harmonizing of the two platforms. r=me

> Source/WebKit/Shared/WebPageCreationParameters.cpp:328
> +#endif

Oh, oops!

> Source/WebKit/UIProcess/WebProcessProxy.h:-364
> -#if ENABLE(ATTACHMENT_ELEMENT) && PLATFORM(IOS_FAMILY)

Nice when everything is in sync!