[webkit-reviews] review granted: [Bug 217335] Promote WKWebView media playback SPI to API : [Attachment 410807] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 9 09:47:55 PDT 2020

Jer Noble <jer.noble at apple.com> has granted katherine_cheney at apple.com's
request for review:
Bug 217335: Promote WKWebView media playback SPI to API

Attachment 410807: Patch


--- Comment #19 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 410807
  --> https://bugs.webkit.org/attachment.cgi?id=410807

View in context: https://bugs.webkit.org/attachment.cgi?id=410807&action=review

R=me with just a couple nits:

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:351
> + WKNoMediaPlayback and the callback will return the error

This makes it sounds like an error will be returned if there’s no media

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:931
> +    return _page->requestMediaPlaybackState([completionHandler =
makeBlockPtr(completionHandler)] (auto&& mediaPlaybackState) {

I think this needs a nil check on completionHandler.

More information about the webkit-reviews mailing list