[webkit-reviews] review granted: [Bug 217508] Implement TCC checks in UserMediaPermissionRequestManagerProxy : [Attachment 410935] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 217508: Implement TCC checks in UserMediaPermissionRequestManagerProxy
https://bugs.webkit.org/show_bug.cgi?id=217508

Attachment 410935: Patch

https://bugs.webkit.org/attachment.cgi?id=410935&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 410935
  --> https://bugs.webkit.org/attachment.cgi?id=410935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410935&action=review

> Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestManagerProxy.mm:155
> +    auto completionHandler = requiresVideoTCCPrompt ? [request =
makeRef(request), callback = WTFMove(callback)](bool isOK) mutable {
> +	   if (!isOK) {
> +	       callback(false);
> +	       return;
> +	   }
> +	   requestAVCaptureAccessForMediaType(WTFMove(callback),
AVMediaTypeVideo);
> +    } : WTFMove(callback);

Very nice!