[webkit-reviews] review denied: [Bug 217479] Sanitize the usage of override sizes : [Attachment 410852] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 217479: Sanitize the usage of override sizes
https://bugs.webkit.org/show_bug.cgi?id=217479

Attachment 410852: Patch

https://bugs.webkit.org/attachment.cgi?id=410852&action=review




--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 410852
  --> https://bugs.webkit.org/attachment.cgi?id=410852
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410852&action=review

Thanks for doing this, I believe this was really needed as it was a mess what
we were storing on those overrides.

There's one test failing yet, so we need to check what's going on before
merging this.

> Source/WebCore/rendering/RenderBox.cpp:95
>  // Used by flexible boxes when flexing this element and by table cells.

Nit: Maybe we want to update this comment, as grid layout also uses these.

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:170
> +    return std::max<LayoutUnit>(0, widthForChild(child) -
child->borderAndPaddingLogicalWidth());

Don't we need to subsctract scrollbar sizes here?