[webkit-reviews] review granted: [Bug 217504] [GLIB] Fix tests compilation warnings with deprecated API : [Attachment 410903] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 217504: [GLIB] Fix tests compilation warnings with deprecated API
https://bugs.webkit.org/show_bug.cgi?id=217504

Attachment 410903: Patch

https://bugs.webkit.org/attachment.cgi?id=410903&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 410903
  --> https://bugs.webkit.org/attachment.cgi?id=410903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410903&action=review

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:443
> +	   auto* websiteDataManager =
webkit_web_view_get_website_data_manager(m_webView);
> +	  
webkit_website_data_manager_set_network_proxy_settings(websiteDataManager,
WEBKIT_NETWORK_PROXY_MODE_CUSTOM, settings);

It doesn't matter in this case because it's the same, but I would get the data
manager from the context instead.