[webkit-reviews] review granted: [Bug 217423] Make it possible to send an arbitrary IPC message from JavaScript : [Attachment 410857] Fixed debug builds

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 217423: Make it possible to send an arbitrary IPC message from JavaScript
https://bugs.webkit.org/show_bug.cgi?id=217423

Attachment 410857: Fixed debug builds

https://bugs.webkit.org/attachment.cgi?id=410857&action=review




--- Comment #10 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 410857
  --> https://bugs.webkit.org/attachment.cgi?id=410857
Fixed debug builds

View in context: https://bugs.webkit.org/attachment.cgi?id=410857&action=review

r=me

> Source/WebKit/ChangeLog:13
> +	   It takes the destination process name (UI, GPU, or Networking), the
destinatoin ID (e.g. WebPageProxy ID),

destination

> Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:131
> +void JSIPC::finalize(JSObjectRef object)
> +{
> +    unwrap(object)->ref();
> +}

No