[webkit-reviews] review granted: [Bug 186612] Ensure the tests are run with US/Pacific time zone : [Attachment 342713] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 186612: Ensure the tests are run with US/Pacific time zone
https://bugs.webkit.org/show_bug.cgi?id=186612

Attachment 342713: Patch

https://bugs.webkit.org/attachment.cgi?id=342713&action=review




--- Comment #14 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 342713
  --> https://bugs.webkit.org/attachment.cgi?id=342713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342713&action=review

> Tools/Scripts/webkitpy/port/base.py:948
> +	   # Some tests fail if the time zone is not set to US/Pacific
(<https://webkit.org/b/186612>)
> +	   clean_env['TZ'] = 'US/Pacific'

Alexey's concern is reasonable. I would add a FIXME: to your comment to make it
clear that this is a concession rather than desired behavior.

Of course it would be nicer if tests didn't depend on timezone, but fixing
every test doesn't seem like a priority. I've never considered running tests
locally to be a reasonable option due to very high number of local failures
that don't occur on bots, and anything to reduce that seems like a good step
towards making it practical to run tests locally.