[webkit-reviews] review granted: [Bug 217294] CSS image-orientation: none should be ignored for cross-origin images : [Attachment 410847] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Noam Rosenthal
<noam at webkit.org>'s request for review:
Bug 217294: CSS image-orientation: none should be ignored for cross-origin
images
https://bugs.webkit.org/show_bug.cgi?id=217294

Attachment 410847: Patch

https://bugs.webkit.org/attachment.cgi?id=410847&action=review




--- Comment #10 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 410847
  --> https://bugs.webkit.org/attachment.cgi?id=410847
Patch

LGTM overall but I hope we can change
http/tests/security/canvas-remote-image-orientation.html so that it passes on
iOS.

View in context: https://bugs.webkit.org/attachment.cgi?id=410847&action=review

> Source/WebCore/ChangeLog:31
> +		   Only apply orientation for eligible images. 

Strange indentation here and above.

> Source/WebCore/html/HTMLImageElement.cpp:690
> +    return image->isOriginClean(&(document().securityOrigin()));

Could be a one liner too.

> LayoutTests/ChangeLog:11
> +		   Added a test to ensure image-orientation: none is not
respected for remote images in canvas

Strange indentation.

> LayoutTests/imported/w3c/ChangeLog:10
> +		   Imported a new W3C test for remote image with
image-orientation.

Strange indentation.

> LayoutTests/platform/ios-simulator-wk2/TestExpectations:11
> +http/tests/security/canvas-remote-image-orientation.html [ ImageOnlyFailure
]

Isn't there a way we could change the test slightly?
It seems the WPT tests are passing, so maybe the idea is to change the canvas
size?

Also, we could migrate that test to http/wpt so that we would more easily reuse
WPT exif-orientation-3-lr.jpg (or even contribute it to WPT at some point).