[webkit-reviews] review granted: [Bug 217439] [GPU Process] Implement VideoPlaybackMetrics : [Attachment 410780] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 217439: [GPU Process] Implement VideoPlaybackMetrics
https://bugs.webkit.org/show_bug.cgi?id=217439

Attachment 410780: Patch

https://bugs.webkit.org/attachment.cgi?id=410780&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 410780
  --> https://bugs.webkit.org/attachment.cgi?id=410780
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410780&action=review

r=me with nit

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h:301
> +    bool m_setShouldUpdatePlaybackMetrics { false };

Nit: this should probably just be `m_shouldUpdatePlaybackMetrics`.