[webkit-reviews] review granted: [Bug 217401] [WebAuthn] Implement a dummy WebAuthenticationAgent : [Attachment 410685] Part 1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jiewen Tan <jiewen_tan at apple.com>'s
request for review:
Bug 217401: [WebAuthn] Implement a dummy WebAuthenticationAgent
https://bugs.webkit.org/show_bug.cgi?id=217401

Attachment 410685: Part 1

https://bugs.webkit.org/attachment.cgi?id=410685&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 410685
  --> https://bugs.webkit.org/attachment.cgi?id=410685
Part 1

View in context: https://bugs.webkit.org/attachment.cgi?id=410685&action=review

> Source/WebKit/ChangeLog:12
> +	   from the UI Process such that we can isolated high privileged
entitlements to this standalone daemon and therefore are able

isolate

> Source/WebKit/ChangeLog:13
> +	   to offer WebAuthn to third party WKWebView clients. One of the
future feautre will require this new process to listen to

“to offer” -> “offer”

“features”

> Source/WebKit/ChangeLog:14
> +	   LaunchEvents, which only daemons can do. That's why it is
implemented as a user agent instead of a xpc service.

XPC

> Source/WebKit/ChangeLog:16
> +	   This is the first part to establish such a dummy daemon. What it
does is to setup a new build target for the daemon and

“First part to establish” -> “first part of establishing” or “first step on the
path of establishing”

“setup”-> “set up”

> Source/WebKit/ChangeLog:34
> +	   Not sure why libWTF.a is needed. Will fix that in the later part.

My guess is that WTFLogAlways is the reason.

> Source/WebKit/Daemons/WebAuthenticationAgent/Info.plist:6
> +	<string>${BUNDLE_VERSION}, Copyright 2003-2020 Apple Inc.</string>

Not sure this needs a copyright going back to 2003

> Source/WebKit/Daemons/WebAuthenticationAgent/Info.plist:22
> +	<string>????</string>

Is this correct?

>
Source/WebKit/Daemons/WebAuthenticationAgent/com.apple.webkit.WebAuthentication
Agent.plist:17
> +    
<string>/Users/jwtan/Documents/Build/Products/Debug/com.apple.WebKit.WebAuthent
icationAgent.Development</string>

Change log does mention this, but it’s not great!

> Source/WebKit/Daemons/WebAuthenticationAgent/main.mm:31
> +	   // FIXME: Implement it.

Don’t need this. We won’t forget.