[webkit-reviews] review granted: [Bug 217375] Add support for MediaRecorder pause/resume : [Attachment 410624] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 7 08:42:32 PDT 2020
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 217375: Add support for MediaRecorder pause/resume
https://bugs.webkit.org/show_bug.cgi?id=217375
Attachment 410624: Patch
https://bugs.webkit.org/attachment.cgi?id=410624&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 410624
--> https://bugs.webkit.org/attachment.cgi?id=410624
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=410624&action=review
> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:237
> +ExceptionOr<void> MediaRecorder::pause()
Tiny nit: "pauseRecording" would be more logical as it is symmetrical with
resume.
More information about the webkit-reviews
mailing list