[webkit-reviews] review granted: [Bug 217427] [LFC][Integration] Add line iterator : [Attachment 410747] patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 217427: [LFC][Integration] Add line iterator
https://bugs.webkit.org/show_bug.cgi?id=217427

Attachment 410747: patch

https://bugs.webkit.org/attachment.cgi?id=410747&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 410747
  --> https://bugs.webkit.org/attachment.cgi?id=410747
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410747&action=review

> Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h:65
> +    float logicalLeft() const { return isHorizontal() ? rect().x() :
rect().y(); }
> +    float logicalRight() const { return isHorizontal() ? rect().maxX() :
rect().maxY(); }
> +    float logicalWidth() const { return isHorizontal() ? rect().width() :
rect().height(); }
> +    float logicalHeight() const { return isHorizontal() ? rect().height() :
rect().width(); }

Assuming that the display items are all flipped from logical to physical during
the layout -> display transition, is this the case when the caller really
expects logical coordinates here and we need to flip them back from physical to
logical (curious about the use case)?