[webkit-reviews] review granted: [Bug 217311] clip-path: path() ignores page zooming (Command-+) : [Attachment 410743] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 7 08:21:45 PDT 2020
Darin Adler <darin at apple.com> has granted Noam Rosenthal <noam at webkit.org>'s
request for review:
Bug 217311: clip-path: path() ignores page zooming (Command-+)
https://bugs.webkit.org/show_bug.cgi?id=217311
Attachment 410743: Patch
https://bugs.webkit.org/attachment.cgi?id=410743&action=review
--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 410743
--> https://bugs.webkit.org/attachment.cgi?id=410743
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=410743&action=review
> Source/WebCore/rendering/style/BasicShapes.cpp:64
> +struct SVGPathTransformedByteStream {
Not new to this patch: this struct should not use m_ prefixes on its public
data members.
> Source/WebCore/rendering/style/BasicShapes.cpp:65
> + SVGPathTransformedByteStream(const FloatPoint& offset, float zoom, const
SVGPathByteStream& rawStream)
Should be able to use aggregate initialization instead of a constructor.
> Source/WebCore/rendering/style/BasicShapes.cpp:123
> +struct TransformedByteStreamPathPolicy : public
TinyLRUCachePolicy<SVGPathTransformedByteStream, Path> {
No need for public here
> Source/WebCore/rendering/style/BasicShapes.cpp:124
> public:
No need for public here
> LayoutTests/imported/w3c/ChangeLog:10
> + Some of them don't pass yet for unrelated reasons, skipped in
TestExpectations.
Expect failure, not skipped. Which is good/better.
More information about the webkit-reviews
mailing list